Review Request 108542: Support for .opus file tags added

Sun Feb 17 04:51:37 UTC 2013

> On Feb. 9, 2013, 1:17 a.m., Matěj Laitl wrote:
> > shared/FileTypeResolver.cpp, lines 20-21
> > <http://git.reviewboard.kde.org/r/108542/diff/2/?file=108702#file108702line20>
> >
> >     Why is including config.h needed for TAGLIB_OPUS_FOUND while it isn't needed for TAGLIB_MOD_FOUND?
> 
> Martin Brodbeck wrote:
>     That's a good question. Are you sure that the TAGLIB_MOD_FOUND part compiles? Here, for the OPUS stuff, I need the include.

The TAGLIB_MOD_FOUND part works for me, when compiling against TagLib 1.8.x. But everywhere where this macro is used there is config.h already included (shared/FileTypeResolver.cpp and shared/tag_helpers/TagHelper.cpp):
http://quickgit.kde.org/?p=amarok.git&a=blob&h=cd531d55771e7d4bed90fa36abae96cae6b59ad1&hb=a9455a6348d9095528a222727755a105cc782812&f=shared%2FFileTypeResolver.cpp
http://quickgit.kde.org/?p=amarok.git&a=blob&h=45340180139b9ac0604ad93483dd9fd725a4cb02&hb=a9455a6348d9095528a222727755a105cc782812&f=shared%2Ftag_helpers%2FTagHelper.cpp

- Mathias Stephan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108542/#review27046
-----------------------------------------------------------

On Feb. 13, 2013, 9:22 a.m., Martin Brodbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108542/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 9:22 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Support for .opus file tags added. Not sure about the mime type. Recent version of taglib necessary.
> 
> 
> This addresses bug 312905.
>     https://bugs.kde.org/show_bug.cgi?id=312905
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f87e05e 
>   shared/FileType.cpp 43d8777 
>   shared/FileTypeResolver.cpp 63a83e1 
>   shared/config.h.cmake 004dd57 
>   shared/tag_helpers/TagHelper.cpp 4534018 
>   shared/FileType.h b3d4470 
>   README c49d284 
> 
> Diff: http://git.reviewboard.kde.org/r/108542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Brodbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130217/f13f9e5f/attachment.html>