<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108542/">http://git.reviewboard.kde.org/r/108542/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 9th, 2013, 1:17 a.m. UTC, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108542/diff/2/?file=108702#file108702line20" style="color: black; font-weight: bold; text-decoration: underline;">shared/FileTypeResolver.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "config.h"</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is including config.h needed for TAGLIB_OPUS_FOUND while it isn't needed for TAGLIB_MOD_FOUND?</pre>
</blockquote>
<p>On February 11th, 2013, 8:10 a.m. UTC, <b>Martin Brodbeck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's a good question. Are you sure that the TAGLIB_MOD_FOUND part compiles? Here, for the OPUS stuff, I need the include.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The TAGLIB_MOD_FOUND part works for me, when compiling against TagLib 1.8.x. But everywhere where this macro is used there is config.h already included (shared/FileTypeResolver.cpp and shared/tag_helpers/TagHelper.cpp):
http://quickgit.kde.org/?p=amarok.git&a=blob&h=cd531d55771e7d4bed90fa36abae96cae6b59ad1&hb=a9455a6348d9095528a222727755a105cc782812&f=shared%2FFileTypeResolver.cpp
http://quickgit.kde.org/?p=amarok.git&a=blob&h=45340180139b9ac0604ad93483dd9fd725a4cb02&hb=a9455a6348d9095528a222727755a105cc782812&f=shared%2Ftag_helpers%2FTagHelper.cpp</pre>
<br />
<p>- Mathias Stephan</p>
<br />
<p>On February 13th, 2013, 9:22 a.m. UTC, Martin Brodbeck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Martin Brodbeck.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2013, 9:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Support for .opus file tags added. Not sure about the mime type. Recent version of taglib necessary.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=312905">312905</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f87e05e)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(43d8777)</span></li>
<li>shared/FileTypeResolver.cpp <span style="color: grey">(63a83e1)</span></li>
<li>shared/config.h.cmake <span style="color: grey">(004dd57)</span></li>
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(4534018)</span></li>
<li>shared/FileType.h <span style="color: grey">(b3d4470)</span></li>
<li>README <span style="color: grey">(c49d284)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108542/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>