Review Request 108906: Add ability to drag titles to re-arrange them in queue manager

[Bartosz Szreder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108906/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

The new ListWidget (PlaylistQueueEditorListWidget - feeling enterprisey today) supports drag'n'drop of self-contained ListItems to itself. On successful dropEvent a signal is emitted, which is intercepted by a new slot reloadQueue() in PlaylistQueueEditor. This slot in turn recreates the queue via The::playlistActions().

Things to consider in future:
- dragging from the playlist into the queue editor 
- making the whole operation more efficient than clearing and recreating whole queue on each dropEvent 
- possibly less hacky way of implementing things? maybe some backend interface would need to be added/exposed for the queue editor? any advice from a seasoned Amarok developer would be very valuable

If this isn't going to be accepted as-is into Amarok codebase then I'm willing to put some time into reworking the solution.


This addresses bug 263563.
    https://bugs.kde.org/show_bug.cgi?id=263563


Diffs
-----

  src/CMakeLists.txt 043dc64 
  src/playlist/PlaylistQueueEditor.h 40b8cdf 
  src/playlist/PlaylistQueueEditor.cpp f647e37 

Diff: http://git.reviewboard.kde.org/r/108906/diff/


Testing
-------

Tested on two different installations, no bugs, regressions or instabilities noticed.


Thanks,

Bartosz Szreder

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130211/84cd2c27/attachment.html>