Review Request 107476: clear filter history

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107476/#review26535
-----------------------------------------------------------


I have seen that a lot of work has been invested in getting the coding style issues corrected.
However I tend to agree with Matěj's comment.

Do we really need it there?
Actually, do we really need it at all? Is there a bug/wish related to this? We have wishes with a couple of hundred votes. 
I never felt the search history in need of cleaning. Expecially since it's cleaned at every restart.

It's sometimes hard to realize (and more so after a lot of work has been invested) that sometimes a nice functionality just isn't worth the increased code complexity, translation and maintenance effort.

- Ralf Engels


On Nov. 26, 2012, 5:45 p.m., Manuel Finessi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107476/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 5:45 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Hi, 
> this patch implement (very simple) clear filter history.
> 
> 
> This addresses bug 310582.
>     https://bugs.kde.org/show_bug.cgi?id=310582
> 
> 
> Diffs
> -----
> 
>   src/dialogs/EditFilterDialog.cpp 4caabd3 
>   src/widgets/SearchWidget.h 897d843 
>   src/widgets/SearchWidget.cpp afa4e7b 
> 
> Diff: http://git.reviewboard.kde.org/r/107476/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> clear button
>   http://git.reviewboard.kde.org/r/107476/s/854/
> 
> 
> Thanks,
> 
> Manuel Finessi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130202/ec6836a0/attachment.html>