<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107476/">http://git.reviewboard.kde.org/r/107476/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have seen that a lot of work has been invested in getting the coding style issues corrected.
However I tend to agree with Matěj's comment.
Do we really need it there?
Actually, do we really need it at all? Is there a bug/wish related to this? We have wishes with a couple of hundred votes.
I never felt the search history in need of cleaning. Expecially since it's cleaned at every restart.
It's sometimes hard to realize (and more so after a lot of work has been invested) that sometimes a nice functionality just isn't worth the increased code complexity, translation and maintenance effort.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On November 26th, 2012, 5:45 p.m. UTC, Manuel Finessi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Manuel Finessi.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2012, 5:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
this patch implement (very simple) clear filter history.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=310582">310582</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dialogs/EditFilterDialog.cpp <span style="color: grey">(4caabd3)</span></li>
<li>src/widgets/SearchWidget.h <span style="color: grey">(897d843)</span></li>
<li>src/widgets/SearchWidget.cpp <span style="color: grey">(afa4e7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107476/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107476/s/854/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/26/schermata2_400x100.png" style="border: 1px black solid;" alt="clear button" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>