Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

Martin Brodbeck martin at brodbeck-online.de
Thu Dec 12 10:51:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114406/
-----------------------------------------------------------

(Updated Dec. 12, 2013, 11:51 a.m.)


Review request for Amarok and Matěj Laitl.


Changes
-------

Err, committing? me? :)
This is done by an active amarok developer, right? Otherwise, someone should tell me, how. ;)
Anyway, I updated the patch with updated Changelog. (Is this diff format better?)


Bugs: 328451
    https://bugs.kde.org/show_bug.cgi?id=328451


Repository: amarok


Description
-------

With this patch, covers from Ogg files (for example Vorbis and Opus) using the recommended METADATA_BLOCK_PICTURE tag will be displayed. This will fix bug #328451. 


Diffs (updated)
-----

  ChangeLog 107aa48 
  shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c 

Diff: http://git.reviewboard.kde.org/r/114406/diff/


Testing
-------


Thanks,

Martin Brodbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131212/ec85ff2c/attachment.html>


More information about the Amarok-devel mailing list