Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag
Matěj Laitl
matej at laitl.cz
Thu Dec 12 10:13:56 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114406/#review45592
-----------------------------------------------------------
Ship it!
Yeah. Please don't forget following tags when comitting, also please add ChangeLog entry:
BUG: 328451
FIXED-IN: 2.9
- Matěj Laitl
On Dec. 11, 2013, 3:45 p.m., Martin Brodbeck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114406/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 3:45 p.m.)
>
>
> Review request for Amarok and Matěj Laitl.
>
>
> Bugs: 328451
> https://bugs.kde.org/show_bug.cgi?id=328451
>
>
> Repository: amarok
>
>
> Description
> -------
>
> With this patch, covers from Ogg files (for example Vorbis and Opus) using the recommended METADATA_BLOCK_PICTURE tag will be displayed. This will fix bug #328451.
>
>
> Diffs
> -----
>
> shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c
>
> Diff: http://git.reviewboard.kde.org/r/114406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Brodbeck
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131212/9e2b256c/attachment.html>
More information about the Amarok-devel
mailing list