Review Request 112365: disable Cover action for UMS albums when the CoverWriteback option is off

[Frank Meerkoetter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112365/
-----------------------------------------------------------

Status
------

This change has been discarded.


Review request for Amarok.


Description
-------

This is not a complete patch but more a request for comment.

My understanding of UMS-albums is that cover related actions like "fetch cover", "set cover", "unset cover" only make sense when the option to write covers back into the media files is enabled. This is not the default in amarok. It was totally confusing to me that amarok was offering me all these actions anyways.

What this patch does it disabled all these cover related actions when they don't make sense anyways (write back is off).
The big problem with this patch is that it will not update the albums (and therefor the state of the actions) when the user toggles the write back option.
So the change in the UI will only be there after the next rescan of the UMS collection. Rescanning (or iterating over all Memory::Meta albums) just to toggle a flag (which the same for all these albums) seems rather pointless.

Any hints how it could be done differently?


Diffs
-----

  src/core-impl/meta/file/File_p.h 5f8b431 

Diff: http://git.reviewboard.kde.org/r/112365/diff/


Testing
-------


Thanks,

Frank Meerkoetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130829/017cba82/attachment.html>