<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112365/">http://git.reviewboard.kde.org/r/112365/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not a complete patch but more a request for comment.
My understanding of UMS-albums is that cover related actions like "fetch cover", "set cover", "unset cover" only make sense when the option to write covers back into the media files is enabled. This is not the default in amarok. It was totally confusing to me that amarok was offering me all these actions anyways.
What this patch does it disabled all these cover related actions when they don't make sense anyways (write back is off).
The big problem with this patch is that it will not update the albums (and therefor the state of the actions) when the user toggles the write back option.
So the change in the UI will only be there after the next rescan of the UMS collection. Rescanning (or iterating over all Memory::Meta albums) just to toggle a flag (which the same for all these albums) seems rather pointless.
Any hints how it could be done differently?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/meta/file/File_p.h <span style="color: grey">(5f8b431)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112365/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>