Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

[Matěj Laitl]

> On Aug. 25, 2013, 2:06 p.m., Matěj Laitl wrote:
> > shared/tag_helpers/APETagHelper.cpp, lines 33-37
> > <http://git.reviewboard.kde.org/r/112266/diff/1/?file=184486#file184486line33>
> >
> >     Hmm, is there a specification somewhere that says what the proper identifiers are? I fear of backwards compatibility, perhaps there are files out there that use the title-cased identifiers?
> 
> Bruno Léon wrote:
>     I did not find specifications for this.
>     Actually when using "Album Artist" instead of "ALBUM ARTIST", the tag is not read at all.
>     Taglib output it as "ALBUM ARTIST" which made me make this correction (and checked it actually works).
>     
>     Same this for compilation. This makes Amarok compliant with Taglib output format.

I don't think that TagLib itself is origin of the string, I think it just reads the identifier that is in the actual tag (which can vary file by file). Or perhaps you can prove me wrong by pointing out relevant part of TagLib source code?


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112266/#review38527
-----------------------------------------------------------


On Aug. 25, 2013, 1:17 p.m., Bruno Léon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112266/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 1:17 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix reading of Album Artist and Compilation tag in APE tags.
> Add support for reading Disc Number in APE tags.
> 
> 
> Diffs
> -----
> 
>   shared/tag_helpers/APETagHelper.cpp c628694 
> 
> Diff: http://git.reviewboard.kde.org/r/112266/diff/
> 
> 
> Testing
> -------
> 
> Tested with Musepack files (that do use APE tags)
> 
> 
> Thanks,
> 
> Bruno Léon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130825/3fe6c04b/attachment.html>