Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

[Bruno Léon]

> On Aug. 25, 2013, 12:06 p.m., Matěj Laitl wrote:
> > shared/tag_helpers/APETagHelper.cpp, lines 33-37
> > <http://git.reviewboard.kde.org/r/112266/diff/1/?file=184486#file184486line33>
> >
> >     Hmm, is there a specification somewhere that says what the proper identifiers are? I fear of backwards compatibility, perhaps there are files out there that use the title-cased identifiers?

I did not find specifications for this.
Actually when using "Album Artist" instead of "ALBUM ARTIST", the tag is not read at all.
Taglib output it as "ALBUM ARTIST" which made me make this correction (and checked it actually works).

Same this for compilation. This makes Amarok compliant with Taglib output format.


> On Aug. 25, 2013, 12:06 p.m., Matěj Laitl wrote:
> > shared/tag_helpers/APETagHelper.cpp, lines 61-65
> > <http://git.reviewboard.kde.org/r/112266/diff/1/?file=184486#file184486line61>
> >
> >     Does the spec say what format does disc number has? Perhaps we should be able to read both formats?

Regarding the Disc Number I looked at how it was done for other tags format.
When you mean "read both" you mean disc number with and without total disc ? (1 vs 1/ for ex.)


- Bruno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112266/#review38527
-----------------------------------------------------------


On Aug. 25, 2013, 11:17 a.m., Bruno Léon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112266/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 11:17 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix reading of Album Artist and Compilation tag in APE tags.
> Add support for reading Disc Number in APE tags.
> 
> 
> Diffs
> -----
> 
>   shared/tag_helpers/APETagHelper.cpp c628694 
> 
> Diff: http://git.reviewboard.kde.org/r/112266/diff/
> 
> 
> Testing
> -------
> 
> Tested with Musepack files (that do use APE tags)
> 
> 
> Thanks,
> 
> Bruno Léon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130825/056c94b1/attachment-0001.html>