Review Request 112255: UMS: Fix set album cover

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112255/#review38516
-----------------------------------------------------------


This review has been submitted with commit c62665ccbd053d83d4f15c39d31027d3a0bcc35f by Mark Kretschmann on behalf of Frank Meerkoetter to branch master.

- Commit Hook


On Aug. 24, 2013, 10:11 p.m., Frank Meerkoetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112255/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 10:11 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> When Setting->Config->Metadata->Write covers to file is enabled, it should be possible to write covers for albums located on an UMS collection. The current status is that amarok does the write but never updates itself to reflect the new cover. There is code to achive this but is has been broken at some point.
> 
> /home/frank/kde/src/amarok/src/core-impl/meta/file/File_p.h:358 tries to create a signal/slot connection (to re-read the tags after the write is done) to an invalid slot. This is fixed by my patch.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/meta/file/File.cpp f2abea4 
>   src/core-impl/meta/file/File_p.h 40f631c 
> 
> Diff: http://git.reviewboard.kde.org/r/112255/diff/
> 
> 
> Testing
> -------
> 
> Writing album covers for files located on an USB stick.
> The album is updated now (collection browser, playlist). The current track applet isn't updating but i guess this is a different problem.
> 
> 
> Thanks,
> 
> Frank Meerkoetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130825/92b3900b/attachment.html>