Review Request 112255: UMS: Fix set album cover

[Frank Meerkoetter]

> On Aug. 24, 2013, 10:26 p.m., Matěj Laitl wrote:
> > Looks good to me, please merge. Dunno how that could have been left broken for such a long time.

Thanks for the review. Can you please merge it? I don't have write access to the amarok repo.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112255/#review38506
-----------------------------------------------------------


On Aug. 24, 2013, 10:11 p.m., Frank Meerkoetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112255/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 10:11 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> When Setting->Config->Metadata->Write covers to file is enabled, it should be possible to write covers for albums located on an UMS collection. The current status is that amarok does the write but never updates itself to reflect the new cover. There is code to achive this but is has been broken at some point.
> 
> /home/frank/kde/src/amarok/src/core-impl/meta/file/File_p.h:358 tries to create a signal/slot connection (to re-read the tags after the write is done) to an invalid slot. This is fixed by my patch.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/meta/file/File.cpp f2abea4 
>   src/core-impl/meta/file/File_p.h 40f631c 
> 
> Diff: http://git.reviewboard.kde.org/r/112255/diff/
> 
> 
> Testing
> -------
> 
> Writing album covers for files located on an USB stick.
> The album is updated now (collection browser, playlist). The current track applet isn't updating but i guess this is a different problem.
> 
> 
> Thanks,
> 
> Frank Meerkoetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130825/0911b6df/attachment-0001.html>