Review Request 112141: Bug 313504: Check validity of i18n calls

Frank Meerkoetter frank at meerkoetter.org
Sun Aug 18 05:42:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112141/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Check validity of i18n calls
    
    See:
    [...]
    Check validity of i18n calls [i18ncheckarg]...OOPS! 4 issues found!
    
        src/widgets/FilenameLayoutWidget.cpp: wrong argument count, have 1 need 0 line# 93 (1)
    [...]

The other issues reported in that section are false positives.
        src/playlistgenerator/constraints/Checkpoint.cpp: wrong argument count, have 0 need 1 line# 170 (1)
        src/playlistgenerator/constraints/TagMatch.cpp: wrong argument count, have 0 need 1 line# 184 (1)
        src/playlistgenerator/constraints/TagMatch.cpp: wrong argument count, have 0 need 4 line# 170 (1)
    [...]


This addresses bug 313504.
    https://bugs.kde.org/show_bug.cgi?id=313504


Diffs
-----

  src/widgets/FilenameLayoutWidget.cpp af6c2da 

Diff: http://git.reviewboard.kde.org/r/112141/diff/


Testing
-------


Thanks,

Frank Meerkoetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130818/c76820a9/attachment.html>


More information about the Amarok-devel mailing list