Review Request 112140: Bug 313504: style: prefer QString::isEmpty() over a "null compare"

[Frank Meerkoetter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112140/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

style: prefer QString::isEmpty() over a "null compare"
    
See:
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
21. Check for compares to QString::null or QString() [nullstrcompare]...OOPS! 2 issues found!
    
src/dialogs/TrackOrganizer.cpp: line# 83 (1)
src/playlistgenerator/PresetModel.cpp: line# 161 (1)
[...]


This addresses bug 313504.
    https://bugs.kde.org/show_bug.cgi?id=313504


Diffs
-----

  src/dialogs/TrackOrganizer.cpp c1d6351 
  src/playlistgenerator/PresetModel.cpp 6a97088 

Diff: http://git.reviewboard.kde.org/r/112140/diff/


Testing
-------


Thanks,

Frank Meerkoetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130818/72e0cd09/attachment-0001.html>