Review Request 110920: Fight warnings.

Albert Astals Cid aacid at kde.org
Thu Aug 15 22:08:45 UTC 2013



> On July 2, 2013, 10:53 a.m., Matěj Laitl wrote:
> > If it compiles with the const, it cannot hurt, ship it!

Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110920/#review35438
-----------------------------------------------------------


On June 9, 2013, 7:53 p.m., Wolf-Michael Bolle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110920/
> -----------------------------------------------------------
> 
> (Updated June 9, 2013, 7:53 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fight warnings.
> 
> Nobody will write that string after it has beed set.
> 
> 
> Diffs
> -----
> 
>   src/services/mp3tunes/libmp3tunes/harmony.h e0941e348db09ba69c39426077b6798e758d6354 
> 
> Diff: http://git.reviewboard.kde.org/r/110920/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolf-Michael Bolle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130815/4b45a3f7/attachment.html>


More information about the Amarok-devel mailing list