Review Request 111991: Better handling of non-writeable UMS collections

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111991/
-----------------------------------------------------------

(Updated Aug. 12, 2013, 8:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Amarok.


Description
-------

If an UMS-collection is non-writeable (think freshly created ext4 on an USB-stick) a copy/move to
collection will silently fail. It can only be seen in the debug logs on the console.

The reason is that the UMS-collection is not actually checking if its writeable. Its just assuming
to be always writeable.

My change consists of two parts:
1. I check if the UMS-collection is actually writeable (mount point and if set the "music folder").
2. To give the user a hint what is going on I added a warning message, informing the user that
   this collection is read-only (otherwise he might be confused why certain operations (move/copy/organize)
   are missing.


Diffs
-----

  src/core-impl/collections/umscollection/UmsCollection.h 749ff81 
  src/core-impl/collections/umscollection/UmsCollection.cpp 028966e 
  src/core-impl/collections/umscollection/UmsCollectionLocation.cpp 1cd1ba8 

Diff: http://git.reviewboard.kde.org/r/111991/diff/


Testing
-------

I have tested with an USB-Stick containing an ext4 filesystem. First i had the base-dir owned by root.root (non-writeable), next i made it writeable and verified that its correctly detected as such. Next i created a "Music" folder and configured it for this USB-Stick. I checked that it was detected as writeable. Next i made the "Music" folder non-writeable and checked that amarok also detected that.


Thanks,

Frank Meerkoetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130812/2a151f7e/attachment.html>