Review Request 110243: Showing hidden files in FileBrowser

[Abhinandan Ramaprasath]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110243/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Patch that adds a context menu in FileBrowser to toggle hidden files.

Problems:
1) I wanted to have a checkbox instead of the icon(temporary) in the context menu. if not possible, atleast a better icon
2) How do I refresh the FileBrowser? I wanted to use SetDir to the same directory but I wasn't able to find an instance of FileBrowser. So the trigger takes place only when the directory is changed. 
3) Bringing up context menu in an empty directory.


This addresses bug 247158.
    https://bugs.kde.org/show_bug.cgi?id=247158


Diffs
-----

  src/browsers/filebrowser/FileBrowser.cpp 167fd33 
  src/browsers/filebrowser/FileView.h df8fbee 
  src/browsers/filebrowser/FileView.cpp 8648c50 

Diff: http://git.reviewboard.kde.org/r/110243/diff/


Testing
-------

yes, works


Thanks,

Abhinandan Ramaprasath

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130429/358bb1e5/attachment.html>