Review Request 110036: WIP - Simple equalizer scripting

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110036/#review31242
-----------------------------------------------------------


Hi,
first thanks for your work. The reviewboard however says for the latest diff:
Diff currently unavailable.
Error: The patch to 'src/EngineController.h' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.RlKFX8' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.RlKFX8/tmpj1DP4Q patch: **** malformed patch at line 17: @@ -292,6 +302,26 @@ public slots:

Please update the patch, checking you upload the correct one. (i.e. a difference between Amarok upstream master and the desired state; parent diff shouldn't be needed if you work on top of Amarok master)

- Matěj Laitl


On April 18, 2013, 8:03 a.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110036/
> -----------------------------------------------------------
> 
> (Updated April 18, 2013, 8:03 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> A new, unambitious attempt at adding equalizer functions to the scripting interface.
> 
> Adds to EngineController the functions:
> * QString eqPreset()
> * void eqApplyPreset(QString name)
> And the signal:
> eqPresetApplied(QString name)
> 
> Adds to AmarokEngineScript the same functions
> set up as a property.
> 
> 
> Diffs
> -----
> 
>   src/EngineController.cpp 28fb256 
>   src/scriptengine/AmarokEngineScript.h f1cdb8c 
>   src/scriptengine/AmarokEngineScript.cpp 4d52bbe 
>   src/EngineController.h 5de4beb 
> 
> Diff: http://git.reviewboard.kde.org/r/110036/diff/
> 
> 
> Testing
> -------
> 
> Quick check using the script console that presets can be changed.
> The preset does get applied but it won't show in the EqualizerDialog.
> Possible other bugs.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130418/4f5ba7b8/attachment-0001.html>