Review Request: MetaFile::Track: only provide statistics stored in tags

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106550/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

MetaFile::Track: only provide statistics stored in tags

As agreed in Randa that non-collection tracks shouldn't use external
tables to store statistics. When user doesn't enable writing stats to
files, we don't even read them in order not to annoy the user.

Also clean up the setter methods in Meta::Track, code sharing+++


Diffs
-----

  ChangeLog 7b58b74eae5f496dc714a78398133e7c08dd96fb 
  src/core-impl/meta/file/File.h 650c79d0f3c6af581c117f33382095db5018c63f 
  src/core-impl/meta/file/File.cpp a3ca501449590d2f43a30a9b288cf51089515bff 
  src/core-impl/meta/file/File_p.h d29d0948047407d5798dd98a21fd75a8f66223f7 
  tests/core-impl/meta/file/TestMetaFileTrack.cpp 6ee7f3c7e79dd1c18caa3549669c670dc3502686 
  tests/core/meta/TestMetaTrack.h 5eb49f0f73266542efb19065cda5acf57be44acc 
  tests/core/meta/TestMetaTrack.cpp 68bc84f8e6fc3efa6d6c5fd74e41808d01edd5af 

Diff: http://git.reviewboard.kde.org/r/106550/diff/


Testing
-------

Works. This is an implementation of what has been agreed on on the requirements/architecture meetings. Running this through review to make sure we all want this.


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120923/6bbdfb90/attachment.html>