<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106550/">http://git.reviewboard.kde.org/r/106550/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matěj Laitl.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">MetaFile::Track: only provide statistics stored in tags
As agreed in Randa that non-collection tracks shouldn't use external
tables to store statistics. When user doesn't enable writing stats to
files, we don't even read them in order not to annoy the user.
Also clean up the setter methods in Meta::Track, code sharing+++</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works. This is an implementation of what has been agreed on on the requirements/architecture meetings. Running this through review to make sure we all want this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(7b58b74eae5f496dc714a78398133e7c08dd96fb)</span></li>
<li>src/core-impl/meta/file/File.h <span style="color: grey">(650c79d0f3c6af581c117f33382095db5018c63f)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(a3ca501449590d2f43a30a9b288cf51089515bff)</span></li>
<li>src/core-impl/meta/file/File_p.h <span style="color: grey">(d29d0948047407d5798dd98a21fd75a8f66223f7)</span></li>
<li>tests/core-impl/meta/file/TestMetaFileTrack.cpp <span style="color: grey">(6ee7f3c7e79dd1c18caa3549669c670dc3502686)</span></li>
<li>tests/core/meta/TestMetaTrack.h <span style="color: grey">(5eb49f0f73266542efb19065cda5acf57be44acc)</span></li>
<li>tests/core/meta/TestMetaTrack.cpp <span style="color: grey">(68bc84f8e6fc3efa6d6c5fd74e41808d01edd5af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106550/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>