Review Request: EngineController: fix playback position resuming for phonon-gst, break it for phonon-vlc <= 0.6.0

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105995/#review22114
-----------------------------------------------------------


This review has been submitted with commit 90f3257d24759e4799ae2c91500901275e81ad3e by Matěj Laitl to branch master.

- Commit Hook


On Nov. 4, 2012, 10:25 a.m., Matěj Laitl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105995/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2012, 10:25 a.m.)
> 
> 
> Review request for Amarok, Harald Sitter and Trever Fischer.
> 
> 
> Description
> -------
> 
> EngineController: fix playback position resuming for phonon-gst, break it for phonon-vlc <= 0.6.0
> 
> Harald, this now waits for you to release phonon-vlc 0.6.1. Would you ming doing so? ;)
> 
> Also, https://git.reviewboard.kde.org/r/107193/ could be seen as a dependency of this patch.
> 
> 
> Diffs
> -----
> 
>   src/EngineController.cpp 32d66e430aefa7f6a08a033e5b75b2dccf98bb27 
> 
> Diff: http://git.reviewboard.kde.org/r/105995/diff/
> 
> 
> Testing
> -------
> 
> 1. Apply to current Amarok master, go to Config -> Playback -> Enable Resume on start.
> 2. Play a track, seek to middle, Quit amarok while it is playing.
> 3. Start Amarok as: amarok -d --nofork 2>&1 | grep 'EngineController'
> 4. See DelayedSeeker debugging messages.
> 
> 
> Thanks,
> 
> Matěj Laitl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121117/2e51b908/attachment.html>