Review Request: EngineController: fix playback position resuming for phonon-gst, break it for phonon-vlc <= 0.6.0

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105995/
-----------------------------------------------------------

(Updated Nov. 4, 2012, 10:25 a.m.)


Review request for Amarok, Harald Sitter and Trever Fischer.


Changes
-------

Update message to reflect that a fix is already in phonon-vlc git (both master and 0.6 branch)


Summary (updated)
-----------------

EngineController: fix playback position resuming for phonon-gst, break it for phonon-vlc <= 0.6.0


Description (updated)
-------

EngineController: fix playback position resuming for phonon-gst, break it for phonon-vlc <= 0.6.0

Harald, this now waits for you to release phonon-vlc 0.6.1. Would you ming doing so? ;)

Also, https://git.reviewboard.kde.org/r/107193/ could be seen as a dependency of this patch.


Diffs
-----

  src/EngineController.cpp 32d66e430aefa7f6a08a033e5b75b2dccf98bb27 

Diff: http://git.reviewboard.kde.org/r/105995/diff/


Testing
-------

1. Apply to current Amarok master, go to Config -> Playback -> Enable Resume on start.
2. Play a track, seek to middle, Quit amarok while it is playing.
3. Start Amarok as: amarok -d --nofork 2>&1 | grep 'EngineController'
4. See DelayedSeeker debugging messages.


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121104/8bdb1635/attachment.html>