Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107161/#review21726
-----------------------------------------------------------

Ship it!


Ship it. Just please convert "else return false;" in possiblyContainsTrack() to
else
    return false;

- Matěj Laitl


On Nov. 9, 2012, 4 p.m., Phalgun Guduthur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107161/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 4 p.m.)
> 
> 
> Review request for Amarok, Edward Hades Toroshchin and Vishesh Handa.
> 
> 
> Description
> -------
> 
> First footstep in completing the Nepomuk Collection. 
> 
> The non virtual methods belonging to TrackProvider implemented.
> Repeated documentation to help vHanda understand the purpose of those functions. 
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/nepomukcollection/NepomukCollection.h d920ff6 
>   src/core-impl/collections/nepomukcollection/NepomukCollection.cpp 0593697 
> 
> Diff: http://git.reviewboard.kde.org/r/107161/diff/
> 
> 
> Testing
> -------
> 
> Minimal.
> 
> 
> Thanks,
> 
> Phalgun Guduthur
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121109/51e94a8c/attachment.html>