Review Request: Fix Transcoding to iPods/iPhone with ffmpeg > 0.10

[Julian Simioni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104839/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

While it seemed to work a while ago (before it was merged to trunk), I recently found that the new ipod manager cannot transcode tracks when sending them to my iPod. I spent some time debugging it and was able to find the cause:

The -map_meta_data option was depricated as of ffmpeg 0.7 and removed in 0.10. Additionally, as far as I can tell the options specified did nothing but explicitly confirm the default option of copying infile metadata to outfile metadata. Please let me know if I'm mistaken about this conclusion.

I also made some small changes to the debug output that should make things slightly cleaner. 

When pulling, please use branch fixTranscode at git://github.com/orangejulius/amarok.git as it has separate commits ready to go :)


Diffs
-----

  src/transcoding/TranscodingJob.cpp 5b30c44 

Diff: http://git.reviewboard.kde.org/r/104839/diff/


Testing
-------

Tested transcoding FLAC music files to ALAC while copying to my iPod classic 160GB


Thanks,

Julian Simioni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120503/aaf33893/attachment.html>