Review Request: GPodder Improvements Patch Rev2

[Lucas Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104335/
-----------------------------------------------------------

(Updated March 25, 2012, 8:34 p.m.)


Review request for Amarok, Stefan Derkits and Bart Cerneels.


Summary (updated)
-----------------

GPodder Improvements Patch Rev2


Description (updated)
-------

GPodder Improvements Patch Rev2

Use Solid::Networking::status() to prevent offline running of any
procedure that requests data from gpodder.net. Fixed some typos in
ChangeLog. Added some extra verifications, to see if suggested podcasts is
ready for use in GpodderServiceModel.

GPodder Improvements Patch Rev1

Put messages to show that gpodder service failed to get data from
gpodder.net. Done some cleanup and added some comments.

GPodder Service improvements

Full status synchronisation implemented. Cleanup and some refactoring.
GPodder Provider saves podcast subscriptions changes if the user closes
amarok before a expected synchronisation to end, so as to synchronize them
in the next start. Forcing GPodderService to verify if the username and
password is not empty before creating a mygpo::ApiRequest. Solved some
problems related to the KWallet use in GPodderService.


Diffs (updated)
-----

  ChangeLog 0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 0a450ae2420de11ab221cf2dec9fc942a7118dd1 
  src/browsers/playlistbrowser/PodcastModel.h e88f4a1dea0b41ce6cc21cdbe3809b99c200b5b8 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6eb970eed241f172cc71396cca8bcaf04b 
  src/core-impl/podcasts/sql/SqlPodcastProvider.h c3d5e56e79c86e2be8c39f47df928bfeb291a920 
  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f652989167952b0c8cf16e742de2fb94e1 
  src/services/gpodder/GpodderPodcastRequestHandler.h 8c12e5f5a5a63b91670fd8081018b7a017a00bbe 
  src/services/gpodder/GpodderPodcastRequestHandler.cpp 66e8ea8a3aeec054c82a180f84d199aba5547f5a 
  src/services/gpodder/GpodderProvider.h 4c724cd763b94515e9e90620ad9a4a3fb8f92e2c 
  src/services/gpodder/GpodderProvider.cpp 6e3255e5f465287a9fad3454cca5a1d2ce47fc6a 
  src/services/gpodder/GpodderService.cpp b518de33e01d20c7293c50e9edbb2dff78419e53 
  src/services/gpodder/GpodderServiceConfig.h 111455aeeb2a579caf1dd938249b8d832a775a89 
  src/services/gpodder/GpodderServiceConfig.cpp 750272e4f2c6c7ad411e9d12c622e97789a29bcd 
  src/services/gpodder/GpodderServiceModel.h 6d31e17cbe2f4cc9799c9b5ea5b18de1f2c282e6 
  src/services/gpodder/GpodderServiceModel.cpp ba1fc9a81cf9240ce655d176a2c81c52f38d326f 
  src/services/gpodder/GpodderServiceSettings.h 81bc218428d2b8bc78235852548a337579b35b24 
  src/services/gpodder/GpodderServiceSettings.cpp 8bb8b806927d1dbac47f2a06887c2e2a6dd3d504 
  src/services/gpodder/GpodderSortFilterProxyModel.h 638fe992cba553cc317febdf049b6b0f301018b5 
  src/services/gpodder/GpodderSortFilterProxyModel.cpp ed1e8301f6f415e86e5367b7827817fff45feb98 

Diff: http://git.reviewboard.kde.org/r/104335/diff/


Testing
-------

This patch should build. Everything is working as expected and there aren't any known issues.


Thanks,

Lucas Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120325/c823031b/attachment-0001.html>