Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104307/
-----------------------------------------------------------

(Updated March 24, 2012, 12:03 p.m.)


Review request for Amarok.


Changes
-------

Refined the patch : Made more sensible function calls, provided documentation, removed unnecessary statements.


Description
-------

This patch implements https://bugs.kde.org/show_bug.cgi?id=214721 . The bookmark is movable within the slider. If it is dragged outside the range, it will revert back to its previous valid location. The bookmark is activated( seek is called ) only when the bookmark is clicked and its position hasn't changed.


Diffs (updated)
-----

  src/amarokurls/AmarokUrl.h 6a1d67f 
  src/amarokurls/AmarokUrl.cpp 19ba210 
  src/amarokurls/BookmarkModel.h 73ae345 
  src/amarokurls/BookmarkModel.cpp 9218088 
  src/amarokurls/ContextUrlGenerator.cpp 16986f6 
  src/amarokurls/NavigationUrlGenerator.cpp d1e21e2 
  src/amarokurls/PlayUrlGenerator.h 131b737 
  src/amarokurls/PlayUrlGenerator.cpp 90e71ff 
  src/context/applets/similarartists/ArtistWidget.cpp 18d8cc2 
  src/context/applets/upcomingevents/UpcomingEventsApplet.cpp 9664201 
  src/core-impl/collections/db/sql/CapabilityDelegateImpl.cpp dc5c500 
  src/playlist/PlaylistViewUrlGenerator.cpp 0ffcb9f 
  src/services/ServiceCapabilities.cpp 6129f8e 
  src/widgets/BookmarkTriangle.h 46e9118 
  src/widgets/BookmarkTriangle.cpp 4c59d42 
  src/widgets/SliderWidget.cpp 5e72e13 

Diff: http://git.reviewboard.kde.org/r/104307/diff/


Testing
-------

Tested it on ubuntu 11.04 with kubuntu-desktop. Works fine for me.


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120324/d5169956/attachment.html>