<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104307/">http://git.reviewboard.kde.org/r/104307/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Jasneet Bhatti.</div>
<p style="color: grey;"><i>Updated March 24, 2012, 12:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refined the patch : Made more sensible function calls, provided documentation, removed unnecessary statements.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements https://bugs.kde.org/show_bug.cgi?id=214721 . The bookmark is movable within the slider. If it is dragged outside the range, it will revert back to its previous valid location. The bookmark is activated( seek is called ) only when the bookmark is clicked and its position hasn't changed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it on ubuntu 11.04 with kubuntu-desktop. Works fine for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/amarokurls/AmarokUrl.h <span style="color: grey">(6a1d67f)</span></li>
<li>src/amarokurls/AmarokUrl.cpp <span style="color: grey">(19ba210)</span></li>
<li>src/amarokurls/BookmarkModel.h <span style="color: grey">(73ae345)</span></li>
<li>src/amarokurls/BookmarkModel.cpp <span style="color: grey">(9218088)</span></li>
<li>src/amarokurls/ContextUrlGenerator.cpp <span style="color: grey">(16986f6)</span></li>
<li>src/amarokurls/NavigationUrlGenerator.cpp <span style="color: grey">(d1e21e2)</span></li>
<li>src/amarokurls/PlayUrlGenerator.h <span style="color: grey">(131b737)</span></li>
<li>src/amarokurls/PlayUrlGenerator.cpp <span style="color: grey">(90e71ff)</span></li>
<li>src/context/applets/similarartists/ArtistWidget.cpp <span style="color: grey">(18d8cc2)</span></li>
<li>src/context/applets/upcomingevents/UpcomingEventsApplet.cpp <span style="color: grey">(9664201)</span></li>
<li>src/core-impl/collections/db/sql/CapabilityDelegateImpl.cpp <span style="color: grey">(dc5c500)</span></li>
<li>src/playlist/PlaylistViewUrlGenerator.cpp <span style="color: grey">(0ffcb9f)</span></li>
<li>src/services/ServiceCapabilities.cpp <span style="color: grey">(6129f8e)</span></li>
<li>src/widgets/BookmarkTriangle.h <span style="color: grey">(46e9118)</span></li>
<li>src/widgets/BookmarkTriangle.cpp <span style="color: grey">(4c59d42)</span></li>
<li>src/widgets/SliderWidget.cpp <span style="color: grey">(5e72e13)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104307/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>