Review Request: Load all tracks from saved playlists using MetaProxy.

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104256/
-----------------------------------------------------------

(Updated March 20, 2012, 12:14 p.m.)


Review request for Amarok.


Changes
-------

Proxy load all saved playlist types: XSPF, PLS, M3U and SQL


Summary (updated)
-----------------

Load all tracks from saved playlists using MetaProxy.


Description
-------

Load all tracks from XSPF using MetaProxy.

Added a worker that does the actual trackForUrl call and subscribes to
trackProviderAdded signal as needed.


This addresses bug 295199.
    https://bugs.kde.org/show_bug.cgi?id=295199


Diffs (updated)
-----

  src/CMakeLists.txt 6e590e8 
  src/core-impl/collections/support/CollectionManager.cpp 37fe03a 
  src/core-impl/meta/proxy/MetaProxy.h d8329be 
  src/core-impl/meta/proxy/MetaProxy.cpp d1577a2 
  src/core-impl/meta/proxy/MetaProxyWorker.h PRE-CREATION 
  src/core-impl/meta/proxy/MetaProxyWorker.cpp PRE-CREATION 
  src/core-impl/meta/proxy/MetaProxy_p.h 792675d 
  src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp c64cb97 
  src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp 67ed68e 
  src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 4cb49fb 
  src/core/collections/support/TrackForUrlWorker.h 64d23bd 
  src/core/collections/support/TrackForUrlWorker.cpp 7e8f289 
  src/playlistmanager/sql/SqlPlaylist.cpp 39ad759 
  src/services/ampache/AmpacheServiceCollection.h a48c8f2 
  src/services/ampache/AmpacheServiceCollection.cpp b684e34 

Diff: http://git.reviewboard.kde.org/r/104256/diff/


Testing
-------

Loaded XSPF attached to https://bugs.kde.org/show_bug.cgi?id=295199 

Could impact AmpacheService. Not checked yet.


Thanks,

Bart Cerneels

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120320/d7ac44b2/attachment.html>