<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104256/">http://git.reviewboard.kde.org/r/104256/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Bart Cerneels.</div>
<p style="color: grey;"><i>Updated March 20, 2012, 12:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Proxy load all saved playlist types: XSPF, PLS, M3U and SQL</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Load all tracks from saved playlists using MetaProxy.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Load all tracks from XSPF using MetaProxy.
Added a worker that does the actual trackForUrl call and subscribes to
trackProviderAdded signal as needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Loaded XSPF attached to https://bugs.kde.org/show_bug.cgi?id=295199
Could impact AmpacheService. Not checked yet.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=295199">295199</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(6e590e8)</span></li>
<li>src/core-impl/collections/support/CollectionManager.cpp <span style="color: grey">(37fe03a)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.h <span style="color: grey">(d8329be)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(d1577a2)</span></li>
<li>src/core-impl/meta/proxy/MetaProxyWorker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/meta/proxy/MetaProxyWorker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy_p.h <span style="color: grey">(792675d)</span></li>
<li>src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp <span style="color: grey">(c64cb97)</span></li>
<li>src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp <span style="color: grey">(67ed68e)</span></li>
<li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: grey">(4cb49fb)</span></li>
<li>src/core/collections/support/TrackForUrlWorker.h <span style="color: grey">(64d23bd)</span></li>
<li>src/core/collections/support/TrackForUrlWorker.cpp <span style="color: grey">(7e8f289)</span></li>
<li>src/playlistmanager/sql/SqlPlaylist.cpp <span style="color: grey">(39ad759)</span></li>
<li>src/services/ampache/AmpacheServiceCollection.h <span style="color: grey">(a48c8f2)</span></li>
<li>src/services/ampache/AmpacheServiceCollection.cpp <span style="color: grey">(b684e34)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104256/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>