Review Request: Add composer button to wikipedia applet

[Ryan McCoskrie]

> On March 18, 2012, 10:22 a.m., Matěj Laitl wrote:
> > src/context/engines/wikipedia/WikipediaEngine.cpp, line 462
> > <http://git.reviewboard.kde.org/r/104327/diff/1/?file=53706#file53706line462>
> >
> >     Hmm, why don't we use i18nc() for creating the pattern here? Something with a very descriptive context string should do. This applies to all cases in the swich, not just this patch.

The strings here are for fetching data from Wikipedia rather than displaying to the user. It seems best to me that such data should be hard coded. That said, I am new to writing translatable software so I'll do some research on how these functions work and take any subsequent advice.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104327/#review11530
-----------------------------------------------------------


On March 18, 2012, 6:27 a.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104327/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 6:27 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Adds a new composer button for the Wikipedia applet.
> 
> Currently only works in English.
> 
> 
> This addresses bug 272982.
>     https://bugs.kde.org/show_bug.cgi?id=272982
> 
> 
> Diffs
> -----
> 
>   src/context/applets/wikipedia/WikipediaApplet_p.h b0d6116 
>   src/context/engines/wikipedia/WikipediaEngine.cpp a4ee870 
>   src/context/applets/wikipedia/WikipediaApplet.h 897a32c 
>   src/context/applets/wikipedia/WikipediaApplet.cpp e326804 
> 
> Diff: http://git.reviewboard.kde.org/r/104327/diff/
> 
> 
> Testing
> -------
> 
> Compiled Amarok, changed a file to have a different musician name to the composer name and pressed button. Everything works as expected.
> This patch is simply a case of copying, pasting, substituteing artist with composer so new bugs are extremely unlikely.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120319/6255c392/attachment.html>