Review Request: SoK - Unit Test : core/collections/QueryMaker

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105172/
-----------------------------------------------------------

(Updated June 23, 2012, 7:02 p.m.)


Review request for Amarok and Sven Krohlas.


Changes
-------

Only setAutoDelete requires any real testing, so tested it using the data driven approach

Not sure if the mock class should be here or in tests/mock . I don't really think this mock is reusable as it implements it's own method and slot, so kept it here.


Description
-------

This is basically a patch creating an empty test for abstract class core/collections/QueryMaker

The test has not been implemented though as the class can only be tested in tests for derived classes implementing the pure virtual functions

It may need to be rewritten and implemented if the class is rewritten in the future


Diffs (updated)
-----

  tests/core/collections/CMakeLists.txt b01b655 
  tests/core/collections/MockQueryMaker.h PRE-CREATION 
  tests/core/collections/MockQueryMaker.cpp PRE-CREATION 
  tests/core/collections/TestQueryMaker.h PRE-CREATION 
  tests/core/collections/TestQueryMaker.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105172/diff/


Testing
-------

Able to build Amarok after writing the test


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120623/7b962887/attachment.html>