Review Request: SoK - Unit Test : core/collections/QueryMaker

Jasneet Bhatti jazneetbhatti at gmail.com
Thu Jun 7 13:40:05 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105172/
-----------------------------------------------------------

(Updated June 7, 2012, 1:40 p.m.)


Review request for Amarok and Sven Krohlas.


Changes
-------

Modified the implementation file to include the correct header file


Description
-------

This is basically a patch creating an empty test for abstract class core/collections/QueryMaker

The test has not been implemented though as the class can only be tested in tests for derived classes implementing the pure virtual functions

It may need to be rewritten and implemented if the class is rewritten in the future


Diffs (updated)
-----

  tests/core/collections/TestQueryMaker.h PRE-CREATION 
  tests/core/collections/TestQueryMaker.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105172/diff/


Testing
-------

Able to build Amarok after writing the test


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120607/bda4611f/attachment.html>


More information about the Amarok-devel mailing list