Review Request: Fix: Recently played tracks are not updated in currrent track applet.

[Conrad Hübler]

> On May 26, 2012, 3:50 p.m., Ralf Engels wrote:
> > Sorry,
> > I can't really see how the fixes will fix "Recently played tracks are not updated in current track applet".
> > This fix does some UI changes and a constant one minute update when amarok is not playing.
> > 
> > You might want to change the title for the review request.

In the older version, after amarok stopped playing, a new tracks was added to the list with: last played within a minute. But that text was not updated, so until restart of amarok it was the whole time played within a minute.

The track list was just loaded correctly during startup, but not correct after some time (wrong last played time). The easiest way is to refresh the list is to update the whole, e.g. every minute. Not to often because of the users cpu.

A final trigger after amarok stoped playing would not update the list after 10 minutes of not playing.

The width will be set back to 184, don't know why I changed it and the trailing spaces will be put somewhere else.


- Conrad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101015/#review14183
-----------------------------------------------------------


On March 29, 2012, 6:07 p.m., Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101015/
> -----------------------------------------------------------
> 
> (Updated March 29, 2012, 6:07 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.
> 
> It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.
> 
> 
> Diffs
> -----
> 
>   src/context/applets/currenttrack/CurrentTrack.h e023e91 
>   src/context/applets/currenttrack/CurrentTrack.cpp 916c829 
>   src/context/applets/currenttrack/currentTrackSettings.ui c006384 
>   src/context/widgets/RecentlyPlayedListWidget.h 37032cb 
>   src/context/widgets/RecentlyPlayedListWidget.cpp 3b7bd72 
> 
> Diff: http://git.reviewboard.kde.org/r/101015/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Conrad Hübler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120610/19c9296b/attachment.html>