<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101015/">http://git.reviewboard.kde.org/r/101015/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 26th, 2012, 3:50 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry,
I can't really see how the fixes will fix "Recently played tracks are not updated in current track applet".
This fix does some UI changes and a constant one minute update when amarok is not playing.
You might want to change the title for the review request.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the older version, after amarok stopped playing, a new tracks was added to the list with: last played within a minute. But that text was not updated, so until restart of amarok it was the whole time played within a minute.
The track list was just loaded correctly during startup, but not correct after some time (wrong last played time). The easiest way is to refresh the list is to update the whole, e.g. every minute. Not to often because of the users cpu.
A final trigger after amarok stoped playing would not update the list after 10 minutes of not playing.
The width will be set back to 184, don't know why I changed it and the trailing spaces will be put somewhere else.</pre>
<br />
<p>- Conrad</p>
<br />
<p>On March 29th, 2012, 6:07 p.m., Conrad Hübler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Conrad Hübler.</div>
<p style="color: grey;"><i>Updated March 29, 2012, 6:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.
It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/currenttrack/CurrentTrack.h <span style="color: grey">(e023e91)</span></li>
<li>src/context/applets/currenttrack/CurrentTrack.cpp <span style="color: grey">(916c829)</span></li>
<li>src/context/applets/currenttrack/currentTrackSettings.ui <span style="color: grey">(c006384)</span></li>
<li>src/context/widgets/RecentlyPlayedListWidget.h <span style="color: grey">(37032cb)</span></li>
<li>src/context/widgets/RecentlyPlayedListWidget.cpp <span style="color: grey">(3b7bd72)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101015/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>