[amarok] /: EditablePlaylistCapability is IMO nonsense, remove it altogether

Matěj Laitl matej at laitl.cz
Wed Jun 6 11:05:49 UTC 2012


On 6. 6. 2012 Bart Cerneels wrote:
> Agreed. The whole Capability idea needs to be re-evaluated. Makes
> little sense outside of Loving tracks in Last.fm streams I think. What
> design pattern is that anyway?

Agreed. Well, I don't think it should go away, but it is currently designed in 
a rather unfortunate way:
 * memory management should be responsibility of the entity, not the caller:
   MetaCapability::has<>() should be is<>() and ::create<>() should be
   ::as<>(). Entities then could multiple-inherit the capabilities and return
   themselves. See Solid::Device.
 * Capabilities are too generic now, they now serve all MetaBase entities and
   Collections. I think caps for just Collection and Meta::Track would suffice.
   Albums have just ActionsCapability that can be now the same for all albums,
   so it is unnecessary generalization.

> Something for the agenda for Randa.

Definitely.

	Matěj


More information about the Amarok-devel mailing list