Review Request: Fix for bug 289751

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103774/#review10036
-----------------------------------------------------------

Ship it!


Good catch. Something that could have been discovered in code review a lot earlier I guess.

Will you commit?

- Bart Cerneels


On Jan. 23, 2012, 9:46 a.m., Volker Christian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103774/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2012, 9:46 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix crash when a device holding a UmsCollection is mounted again after an unmount without removing the device in between. This will fix bug 289751.
> 
> The crash occours because the QSharedPointer m_mc is cleared during an unmount but not initialized when mounted again. I fixed this issue by initializing m_mc in the init-method and not in the constructor.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/umscollection/UmsCollection.cpp df3445f 
> 
> Diff: http://git.reviewboard.kde.org/r/103774/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volker Christian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120124/dc70dbbd/attachment.html>