Review Request: Fix for bug 289751

Volker Christian volker.christian at fh-hagenberg.at
Mon Jan 23 09:46:08 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103774/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Fix crash when a device holding a UmsCollection is mounted again after an unmount without removing the device in between. This will fix bug 289751.

The crash occours because the QSharedPointer m_mc is cleared during an unmount but not initialized when mounted again. I fixed this issue by initializing m_mc in the init-method and not in the constructor.


Diffs
-----

  src/core-impl/collections/umscollection/UmsCollection.cpp df3445f 

Diff: http://git.reviewboard.kde.org/r/103774/diff/diff


Testing
-------


Thanks,

Volker Christian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120123/183ea9bf/attachment.html>


More information about the Amarok-devel mailing list