Review Request: Update playlist selection at an appropriate time when text changed in search widget

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101974/#review9983
-----------------------------------------------------------


This review has been submitted with commit d8d15b9f2c990ab298620f701943848601d6bd5b by Ralf Engels to branch master.

- Commit Hook


On July 17, 2011, 6:06 a.m., Thomas Karpiniec wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101974/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 6:06 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> When "show only matches" is enabled the listview tries to select the track and emit a signal about whether or not it matched before the proxy timeout has triggered the update. This happens to work anyway when additional keystrokes are narrowing the results but causes problems when I typo. For example, in my play list, "laz" returns 15 results and "lazz" returns 0. If I then backspace the second "z", it doesn't select the top track and the lineedit widget still appears in red.
> 
> This is a fairly direct solution: moving the relevant selection code to the timeout handler with some member vars to store the required arguments. If there's a better way to go about it please let me know and I'll try to bring it up to scratch.
> 
> 
> Diffs
> -----
> 
>   src/playlist/view/listview/PrettyListView.h f22a7c8 
>   src/playlist/view/listview/PrettyListView.cpp 9ce6573 
> 
> Diff: http://git.reviewboard.kde.org/r/101974/diff/diff
> 
> 
> Testing
> -------
> 
> Applied against master. Tried it with a bunch of different patterns and left it for a while.
> The only issue I've noticed is that if the list is empty and you press backspace then enter in quick succession, it will apply the "enter" to the empty list rather than the one that appears after the timeout. It's an existing problem though. Might look at that separately.
> 
> 
> Thanks,
> 
> Thomas Karpiniec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120121/0567e731/attachment.html>