Review Request: Enable find as you type support in the playlist

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102442/#review9982
-----------------------------------------------------------


Been thinking about it.
It's a nice functionality, but also hard to discover.

If one would read the code, one would not readily understand why the code is there and what it does.

So I would say that we include it if it's better commented.
Could you add more comments? Maybe even for the class to describe the complete key event behaviour?

- Ralf Engels


On Aug. 26, 2011, 9:47 a.m., Nikhil Shantanu Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102442/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 9:47 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> If playlist has focus, typing characters switches focus to the search widget and the filter is applied.
> 
> The change is not very big, but do we want this capability?
> 
> 
> This addresses bug 192125.
>     https://bugs.kde.org/show_bug.cgi?id=192125
> 
> 
> Diffs
> -----
> 
>   src/playlist/PlaylistDock.h d8bbeed 
>   src/playlist/PlaylistDock.cpp 504f63c 
>   src/playlist/view/listview/PrettyListView.h f22a7c8 
>   src/playlist/view/listview/PrettyListView.cpp 9ce6573 
> 
> Diff: http://git.reviewboard.kde.org/r/102442/diff/diff
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Nikhil Shantanu Marathe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120121/3eb14170/attachment-0001.html>