Review Request: initialize m_bpm field in TimecodeMetac class

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104024/#review10754
-----------------------------------------------------------

Ship it!


Good catch.

Are there any bugs (potentially) fixed by this? Perhaps you can find some more uninitialized qreals and fix them all in one big commit?

- Bart Cerneels


On Feb. 19, 2012, 6:38 p.m., Andriy Gapon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104024/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2012, 6:38 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Uninitialized double (qreal) field can get an arbitrary value including exotics like NaN, denormalized numbers etc.
> This could lead to surprises in the code that doesn't expect an "unreal" values - e.g. any logical with NaN always returns false.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/meta/timecode/TimecodeMeta.cpp 5ebe859 
> 
> Diff: http://git.reviewboard.kde.org/r/104024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andriy Gapon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120220/4e64eac8/attachment.html>