Review Request: initialize m_bpm field in TimecodeMetac class

Andriy Gapon avg at icyb.net.ua
Sun Feb 19 18:38:25 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104024/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Uninitialized double (qreal) field can get an arbitrary value including exotics like NaN, denormalized numbers etc.
This could lead to surprises in the code that doesn't expect an "unreal" values - e.g. any logical with NaN always returns false.


Diffs
-----

  src/core-impl/meta/timecode/TimecodeMeta.cpp 5ebe859 

Diff: http://git.reviewboard.kde.org/r/104024/diff/


Testing
-------


Thanks,

Andriy Gapon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120219/3fe7d961/attachment.html>


More information about the Amarok-devel mailing list