Review Request: Bug 173814 - JJ: add keyboard shortcut for "Edit Track Information..."

[Jasneet Bhatti]

> On Feb. 15, 2012, 8:08 a.m., Bart Cerneels wrote:
> > Except for that one capital 'O' it's perfect and can be merged.
> > Very good work Jasneet. I'd be more then happy to review more junior jobs from you.

I was trying to post this round about the same time I uploaded the final patch but my internet connection went down and is back on only now.

Thanks for the compliments and more so for the help and reviews. Everyone has been extremely supportive and encouraging, and I'm motivated to keep working and contributing to the community.

On to the next one.....


- Jasneet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103960/#review10650
-----------------------------------------------------------


On Feb. 15, 2012, 8:25 a.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103960/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2012, 8:25 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch fixes the bug : https://bugs.kde.org/show_bug.cgi?id=173814
> 
> I've created a new slot that is called when the key combination is pressed. This slot in turn calls the concerned function to display Edit Track Details dialog.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h 984aa28 
>   src/MainWindow.cpp ea99659 
>   src/playlist/PlaylistDock.h 897be1d 
>   src/playlist/PlaylistDock.cpp b217e3c 
> 
> Diff: http://git.reviewboard.kde.org/r/103960/diff/
> 
> 
> Testing
> -------
> 
> I've tested this on ubuntu 11.10 with kubuntu-desktop and it seems to work fine.
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120216/d65bf8c9/attachment.html>