<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103960/">http://git.reviewboard.kde.org/r/103960/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 15th, 2012, 8:08 a.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Except for that one capital 'O' it's perfect and can be merged.
Very good work Jasneet. I'd be more then happy to review more junior jobs from you.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was trying to post this round about the same time I uploaded the final patch but my internet connection went down and is back on only now.
Thanks for the compliments and more so for the help and reviews. Everyone has been extremely supportive and encouraging, and I'm motivated to keep working and contributing to the community.
On to the next one.....</pre>
<br />
<p>- Jasneet</p>
<br />
<p>On February 15th, 2012, 8:25 a.m., Jasneet Bhatti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Jasneet Bhatti.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2012, 8:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes the bug : https://bugs.kde.org/show_bug.cgi?id=173814
I've created a new slot that is called when the key combination is pressed. This slot in turn calls the concerned function to display Edit Track Details dialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested this on ubuntu 11.10 with kubuntu-desktop and it seems to work fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.h <span style="color: grey">(984aa28)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(ea99659)</span></li>
<li>src/playlist/PlaylistDock.h <span style="color: grey">(897be1d)</span></li>
<li>src/playlist/PlaylistDock.cpp <span style="color: grey">(b217e3c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103960/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>