Review Request: Fix failure to rip CD tracks with special characters in their title

Björn Steinbrink b.steinbrink at gmx.de
Wed Feb 1 21:00:37 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103841/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Fix failure to rip CD tracks with special characters in their title

Certain characters such as ? have a special meaning in URLs so they have
to be encoded when used in path component, but the AudioCdCollection
fails to do so and just embeds the raw track title into the URL. Thus it
is impossible to rip tracks that contain such characters in their title,
as the URL passed to the KIO subsystem is invalid.


This addresses bug 224437.
    https://bugs.kde.org/show_bug.cgi?id=224437


Diffs
-----

  src/core-impl/collections/audiocd/AudioCdCollection.cpp a6fb0372522aef1f92baaacc219cb2e4a2da1499 

Diff: http://git.reviewboard.kde.org/r/103841/diff/diff


Testing
-------

Successfully ripped multiple tracks with question marks in their title.


Thanks,

Björn Steinbrink

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120201/1142be83/attachment.html>


More information about the Amarok-devel mailing list