Review Request: Fix failure to rip CD tracks with special characters in their title

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103841/#review10276
-----------------------------------------------------------

Ship it!


Good work, Björn, this looks absolutely sane, I will push this later today.

- Matěj Laitl


On Feb. 1, 2012, 9 p.m., Björn Steinbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103841/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2012, 9 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix failure to rip CD tracks with special characters in their title
> 
> Certain characters such as ? have a special meaning in URLs so they have
> to be encoded when used in path component, but the AudioCdCollection
> fails to do so and just embeds the raw track title into the URL. Thus it
> is impossible to rip tracks that contain such characters in their title,
> as the URL passed to the KIO subsystem is invalid.
> 
> 
> This addresses bug 224437.
>     https://bugs.kde.org/show_bug.cgi?id=224437
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/audiocd/AudioCdCollection.cpp a6fb0372522aef1f92baaacc219cb2e4a2da1499 
> 
> Diff: http://git.reviewboard.kde.org/r/103841/diff/diff
> 
> 
> Testing
> -------
> 
> Successfully ripped multiple tracks with question marks in their title.
> 
> 
> Thanks,
> 
> Björn Steinbrink
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120201/c0e423be/attachment.html>