Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

[Matěj Laitl]

> On Aug. 17, 2012, 12:12 p.m., Ralf Engels wrote:
> > I would like to reject this request. I still don't know what the reason for this change request is (displaying something different somewhere, why?) and the change is done at the wrong place (it breaks the model instead of just changing the view).

Agreed. While I understand the bug, it should be solved at very different place.

As Bart says, playlists::description() should be removed entirely (please also remove all its occurences in subclasses), and the playlist model should be updated to return the name for Qt::ToolTipRole() too. (in its data()) method)


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104048/#review17588
-----------------------------------------------------------


On Feb. 23, 2012, 4:49 p.m., Claudio Desideri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104048/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2012, 4:49 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> My first attempt to contribute.
> 
> 
> This addresses bug 275821.
>     https://bugs.kde.org/show_bug.cgi?id=275821
> 
> 
> Diffs
> -----
> 
>   src/playlistmanager/sql/SqlPlaylist.h a001194 
> 
> Diff: http://git.reviewboard.kde.org/r/104048/diff/
> 
> 
> Testing
> -------
> 
> It works. :P
> 
> 
> Thanks,
> 
> Claudio Desideri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120817/6cb53b11/attachment-0001.html>