Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

Ralf Engels ralf-engels at gmx.de
Fri Aug 17 12:12:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104048/#review17587
-----------------------------------------------------------


I would like to reject this request. I still don't know what the reason for this change request is (displaying something different somewhere, why?) and the change is done at the wrong place (it breaks the model instead of just changing the view).

- Ralf Engels


On Feb. 23, 2012, 4:49 p.m., Claudio Desideri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104048/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2012, 4:49 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> My first attempt to contribute.
> 
> 
> This addresses bug 275821.
>     https://bugs.kde.org/show_bug.cgi?id=275821
> 
> 
> Diffs
> -----
> 
>   src/playlistmanager/sql/SqlPlaylist.h a001194 
> 
> Diff: http://git.reviewboard.kde.org/r/104048/diff/
> 
> 
> Testing
> -------
> 
> It works. :P
> 
> 
> Thanks,
> 
> Claudio Desideri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120817/fb20f088/attachment.html>


More information about the Amarok-devel mailing list