[amarok] src/services/amazon: Detect Amazon country automatically.

[Edward Hades]

On Wed, Aug 15, 2012 at 01:18:42AM +0200, Sven Krohlas wrote:
> I'm very opposed to that solution, as now the plugin sends queries
> to the service even without having an explicit users consent. Sending
> data to a web service without the user knowing about it is a bad thing.

First, the commit in question does not introduce the behavior you
oppose. The dialog did not ask for user's consent, it just asked where
she were. Now Amarok just takes a wildish guess.

Second, if "not sending data to a web service without the user knowing"
were to be made Amarok's policy, it should be applied everywhere, not
just to Amazon's store. Currently, for example, Magnatune store
downloads stuff without asking anyone.

And it definitely has nothing to do with removing an annoying dialog.

> The KCModule should be shown embedded in the service browser, if no
> valid country has been set.

Yeah, that'd be nice.

Cheers,
-- 
Edward "Hades" Toroshchin
dr_lepper on irc.freenode.org