Review Request: Fix crash when closing Amarok with running CoverFetcher

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105942/#review17141
-----------------------------------------------------------


Looks good, just a few small things. Could you also please describe the steps that lead to the crash in the commit msg?


src/statusbar/CompoundProgressBar.h
<http://git.reviewboard.kde.org/r/105942/#comment13406>

    Please document the fact that this class is now completely thread-safe. (or, if not, document that it is reentrant and some methods are thread-safe, then document every thread-safe method)



src/statusbar/CompoundProgressBar.cpp
<http://git.reviewboard.kde.org/r/105942/#comment13405>

    Nitpicky: I would personally strip all the added newlines


- Matěj Laitl


On Aug. 9, 2012, 10:36 a.m., Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105942/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 10:36 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> childBarFinished was called with invalid m_progressDetailsWidget
> However also the m_progressMap needs protection. The CompoundProgressBar needs to be thread safe.
> 
> 
> This addresses bug 292553.
>     https://bugs.kde.org/show_bug.cgi?id=292553
> 
> 
> Diffs
> -----
> 
>   src/statusbar/CompoundProgressBar.h baaab94 
>   src/statusbar/CompoundProgressBar.cpp 371a534 
> 
> Diff: http://git.reviewboard.kde.org/r/105942/diff/
> 
> 
> Testing
> -------
> 
> Change is verified by me to fix the problem.
> 
> 
> Thanks,
> 
> Ralf Engels
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120809/69f5bc50/attachment.html>